-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1688
https://issues.apache.org/jira/browse/MESOS-1688
Repository: mesos-git
Description
-------
As already explained in JIRA MESOS-1688, there are schedulers allocating memory
only for the executor and not for tasks. For tasks only CPU resources are
allocated in this case.
Such a scheduler does not get offered any idle CPUs if the slave has nearly
used up all memory.
This can easily lead to a dead lock (in the application, not in Mesos).
Simple example:
1. Scheduler allocates all memory of a slave for an executor
2. Scheduler launches a task for this executor (allocating 1 CPU)
3. Task finishes: 1 CPU , 0 MB memory allocatable.
4. No offers are made, as no memory is left. Scheduler will wait for offers
forever. Dead lock in the application.
To fix this problem, offers must be made if CPU resources are allocatable
without considering allocatable memory
Diffs
-----
src/master/hierarchical_allocator_process.hpp
34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52
Diff: https://reviews.apache.org/r/25035/diff/
Testing
-------
`make` and `make check` executed.
Allocation tests succeeded.
On my machine the test `MasterTest.MetricsInStatsEndpoint` failed both with and
without the patch. So I'm not sure if all tests were executed.
Thanks,
Martin Weindel
