----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24877/#review51488 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Aug. 26, 2014, 1:56 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24877/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 1:56 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Boost's variant supports the streaming operator, so the visitor pattern is > unnecessary: > http://www.boost.org/doc/libs/1_55_0/doc/html/boost/operator_idp53065304.html > http://www.boost.org/doc/libs/1_55_0/doc/html/variant/tutorial.html#variant.tutorial.basic > > Not only is it unnecessary, the visitor pattern here leads to poor logging > when json types are used in google test assertions. This is because google > test cannot resolve that a json::Object should be printed through the << > operator for json::Value. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > d98d953957e3bca11d311d570ccad0f306cc43c7 > > Diff: https://reviews.apache.org/r/24877/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
