-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25075/#review51597
-----------------------------------------------------------
Bad patch!
Reviews applied: [25075]
Failed command: ./support/mesos-style.py
Error:
Checking 505 files using filter
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp:82: Missing space
around colon in range-based for loop [whitespace/forcolon] [2]
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp:92: Redundant blank
line at the end of a code block should be deleted. [whitespace/blank_line] [3]
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp:122: Namespace
should be terminated with "// namespace path {" [readability/namespace] [5]
Total errors found: 3
- Mesos ReviewBot
On Aug. 26, 2014, 9:12 p.m., Patrick Reilly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25075/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 9:12 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-1733
> https://issues.apache.org/jira/browse/MESOS-1733
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Changed the stout path utility to declare a single, variadic 'join' function
> instead of several separate declarations of various discrete arities
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a
>
> Diff: https://reviews.apache.org/r/25075/diff/
>
>
> Testing
> -------
>
> Ran "make check" working on creating a new unit test.
>
>
> Thanks,
>
> Patrick Reilly
>
>
