----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review51633 -----------------------------------------------------------
Bad patch! Reviews applied: [25079] Failed command: ./support/mesos-style.py Error: Checking 506 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/include/process/help.hpp:61: public: should not be indented inside class TLineHelper [whitespace/indent] [3] 3rdparty/libprocess/include/process/help.hpp:72: public: should not be indented inside class TLineHelper [whitespace/indent] [3] 3rdparty/libprocess/src/help.cpp:77: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:78: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:124: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:136: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:139: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:154: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 8 - Mesos ReviewBot On Aug. 26, 2014, 9:44 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25079/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 9:44 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1734 > https://issues.apache.org/jira/browse/MESOS-1734 > > > Repository: mesos-git > > > Description > ------- > > Reduce compile time: - replacing a macro expansion with a variadic template > - moving implementation from help.hpp to help.cpp > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am edbe54b > 3rdparty/libprocess/include/process/help.hpp 4333b5b > 3rdparty/libprocess/src/help.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25079/diff/ > > > Testing > ------- > > Ran "make check". > > > Thanks, > > Patrick Reilly > >
