> On Aug. 28, 2014, 10:25 p.m., Dominic Hamon wrote: > > a quick high-level note that it's generally prefered that patches are split > > along stout, libprocess, and mesos boundaries. you can set reviewboard > > patches to depend on other ones to ensure that they land together.
[~dhamon] Okay I'll make the modifications. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25167/#review51840 ----------------------------------------------------------- On Aug. 28, 2014, 10:21 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25167/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 10:21 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1744 > https://issues.apache.org/jira/browse/MESOS-1744 > > > Repository: mesos-git > > > Description > ------- > > Use compiler intrinsics for unreachable, exit, and abort > Makes the functions not need to pretend to return something while > still silencing the compiler warnings. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp f20feea > 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5bbf829 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896 > 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 > 3rdparty/libprocess/src/process.cpp 3ac56c7 > 3rdparty/libprocess/src/subprocess.cpp 5b92200 > src/log/leveldb.cpp 2967a1f > src/log/network.hpp fc85a57 > src/slave/containerizer/mesos/launch.cpp 9819381 > src/tests/routing_tests.cpp 10730ad > src/zookeeper/zookeeper.cpp 72c9fc3 > > Diff: https://reviews.apache.org/r/25167/diff/ > > > Testing > ------- > > This is currently a work in progress, (WIP) > > > Thanks, > > Patrick Reilly > >
