----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/#review51945 -----------------------------------------------------------
Patch looks great! Reviews applied: [25084] All tests passed. - Mesos ReviewBot On Aug. 29, 2014, 7:07 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25084/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 7:07 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1733 > https://issues.apache.org/jira/browse/MESOS-1733 > > > Repository: mesos-git > > > Description > ------- > > Changed the stout path utility to declare a single, variadic 'join' function > instead of several separate declarations of various discrete arities > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am db9766d > 3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25084/diff/ > > > Testing > ------- > > Ran "make check" created path_tests unit test. > > > Thanks, > > Patrick Reilly > >
