-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51948
-----------------------------------------------------------


Bad patch!

Reviews applied: [25105]

Failed command: ./support/mesos-style.py

Error:
 Checking 506 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/tests/isolator_tests.cpp:903:  Could not find a newline character at the 
end of the file.  [whitespace/ending_newline] [5]
Total errors found: 1

- Mesos ReviewBot


On Aug. 29, 2014, 8:36 p.m., Patrick Reilly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25105/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 8:36 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-350
>     https://issues.apache.org/jira/browse/MESOS-350
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Currently there is no disk isolation in place and this affects an executor to 
> be starved of disk when another disk heavy operation such as copying a multi 
> gigabyte file is being performed by another executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto dea51f9 
>   src/Makefile.am 40b9f6b 
>   src/linux/cgroups.hpp abf31df 
>   src/linux/cgroups.cpp 989e307 
>   src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 5116b14 
>   src/tests/isolator_tests.cpp c38f876 
> 
> Diff: https://reviews.apache.org/r/25105/diff/
> 
> 
> Testing
> -------
> 
> In progress.
> 
> 
> Thanks,
> 
> Patrick Reilly
> 
>

Reply via email to