----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/#review52143 -----------------------------------------------------------
Patch looks great! Reviews applied: [25205] All tests passed. - Mesos ReviewBot On Sept. 2, 2014, 8:43 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25205/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 8:43 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Fix command executor path check. > > > Currently we expand the symlinks when we assign the command executor path > when we write the ExecutorInfo's command value, but we don't do the same when > we perform a string match later to check if the Executor is a commandExecutor. > > > This patches fixes so it does both on both place. > > > Diffs > ----- > > src/slave/slave.hpp 9d4607ef126f40ade9c861e3ea0eb41f10a3dff9 > src/slave/slave.cpp 5c76dd1b9d3f7d262053aa4c20ebc2e8a00a0f4e > > Diff: https://reviews.apache.org/r/25205/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
