> On Sept. 5, 2014, 9:46 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 897 > > <https://reviews.apache.org/r/25371/diff/1/?file=679923#file679923line897> > > > > period at the end?
done. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25371/#review52511 ----------------------------------------------------------- On Sept. 9, 2014, 12:41 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25371/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:41 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1715 > https://issues.apache.org/jira/browse/MESOS-1715 > > > Repository: mesos-git > > > Description > ------- > > Not sending the pending tasks leads to the master considering them lost when > it reconciles its state! > > > Diffs > ----- > > src/common/protobuf_utils.hpp 809e4b2b702934c460c7e02439349f6148c470e8 > src/common/protobuf_utils.cpp 1714ef75309624bca17baeefa9839dfe78d589bd > src/slave/slave.hpp 062e961a0ff2cfa88057a0d01114375cb86ffd24 > src/slave/slave.cpp bd31831022c97e68b0293d66e1eb5f28ac508525 > src/tests/common/http_tests.cpp 5fa51bf1c100805ebd997c20ce020d4ca11664be > src/tests/slave_recovery_tests.cpp 357edfc134e825036aeea58ca0b66bb48f3d08e9 > > Diff: https://reviews.apache.org/r/25371/diff/ > > > Testing > ------- > > Test added in the review chain. > > > Thanks, > > Ben Mahler > >
