----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25237/#review52761 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/25237/#comment91813> Let's put a new line after this and before the comment to make it easier. I'd even put it below the comment with a newline after that before doing the splitting. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/25237/#comment91815> While 'inspect' is a bit harder to implement because we've already got an 'inspect' which returns a Docker::Container, why not make all of this Docker::pull? This would be a nice clean addition to the Docker class as it's own review, where we could add a test, and keep the code in DockerContainerizerProcess from getting too Docker CLI specific. I know in the heat of the moment we put this stuff in here to get 0.20.0 out but now we should really be more pedantic! ;-) Small change, sound good? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/25237/#comment91814> Indentation. - Benjamin Hindman On Sept. 1, 2014, 7:16 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25237/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 7:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Avoid Docker pull on each run. > > Currently each Docker run will run a docker pull which calls the docker > registry each time. > To avoid this this patch adds a docker inspect <image> and skip calling pull > if it already exists. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a > > Diff: https://reviews.apache.org/r/25237/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
