----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52764 -----------------------------------------------------------
Looking good! include/mesos/mesos.proto <https://reviews.apache.org/r/25270/#comment91819> Any reason not to do s/NetworkMode/Network/ instead? include/mesos/mesos.proto <https://reviews.apache.org/r/25270/#comment91824> Do you want to make this an enum too? Maybe not, but what happens if someone puts in 'TCP' instead of 'tcp'? src/docker/docker.cpp <https://reviews.apache.org/r/25270/#comment91826> How about keeping this close to where we actually 'argv.push(network)' below please? src/docker/docker.cpp <https://reviews.apache.org/r/25270/#comment91828> & src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/25270/#comment91832> Ultimately it would be great to get this under the 'mesos' registry so other folks can easily make changes to the executor too. src/tests/docker_tests.cpp <https://reviews.apache.org/r/25270/#comment91835> Is there something you actually want to test for? Like being able to send to a mapped port and have it show up on a command listening on the internal port? Is there 'nc' or 'telnet' in busybox that you can assume to get the output of any data sent to the internal port? - Benjamin Hindman On Sept. 5, 2014, 4:55 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25270/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 4:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. > > > Bugs: MESOS-1621 > https://issues.apache.org/jira/browse/MESOS-1621 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/25270 > > > Diffs > ----- > > include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 > src/common/resources.cpp 29fc765f1a4c023d91e348cacd5b6333d351a5ac > src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e > src/slave/slave.cpp bd31831022c97e68b0293d66e1eb5f28ac508525 > src/tests/docker_containerizer_tests.cpp > 8654f9c787bd207f6a7b821651e0c083bea9dc8a > src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 > > Diff: https://reviews.apache.org/r/25270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
