> On Sept. 10, 2014, 7:06 p.m., Cong Wang wrote:
> > Maybe check if /proc/sys/net/ipv6/conf/all/disable_ipv6 exists in child 
> > script too since you did outside?

It's OK, if the proc file does not exist, it'll be a no-op as we don't use set 
-e.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25512/#review52918
-----------------------------------------------------------


On Sept. 10, 2014, 6:26 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25512/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 6:26 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. Since we are not forwarding IPv6 packets, it doesn't make sense 
> to enable ipv6. By disabling IPv6, we won't get spamming kernel log warning 
> duplicated IPv6 addresses since all veth have the same mac.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 938782ae2ab1da34eb316381131e9bfcb7c810d1 
> 
> Diff: https://reviews.apache.org/r/25512/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to