----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/#review52998 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Sept. 10, 2014, 6 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25487/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 6 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1676 > https://issues.apache.org/jira/browse/MESOS-1676 > > > Repository: mesos-git > > > Description > ------- > > - On slower machines sometimes the zookeeper c client times out where we > aren't expecting because either the test server or the client is too slow to > respond. Increasing this value helps mitigate the problem. > - The effect of "server->shutdownNetwork()" is immediate so this won't > prolong the tests so long as they don't wait for session expiration without > clock advances, which I have checked and there is none. > > > Diffs > ----- > > src/tests/master_contender_detector_tests.cpp > 9ac59aa446a132e734238e0e55801117c4ef31b4 > src/tests/zookeeper.cpp e45f956e1486e952a4efeb123e15568518fb53fe > > Diff: https://reviews.apache.org/r/25487/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
