> On Sept. 11, 2014, 4:56 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/filesystem/shared.cpp, line 124 > > <https://reviews.apache.org/r/25549/diff/1/?file=686147#file686147line124> > > > > s/host_path/hostPath/
is this style strictly enforced? It matches the snaked cased Volume.host_path. > On Sept. 11, 2014, 4:56 p.m., Vinod Kone wrote: > > src/slave/flags.hpp, line 28 > > <https://reviews.apache.org/r/25549/diff/1/?file=686150#file686150line28> > > > > I don't think you need this header in this file? Believe necessary for parsing the Option<ContainerInfo> flag. > On Sept. 11, 2014, 4:56 p.m., Vinod Kone wrote: > > src/tests/isolator_tests.cpp, line 757 > > <https://reviews.apache.org/r/25549/diff/1/?file=686152#file686152line757> > > > > Is this guaranteed to exist on all systems? (practically) yes. It's part of FHS and followed by OSX, Linux, *BSD. http://www.tldp.org/LDP/sag/html/var-fs.html http://www.pathname.com/fhs/2.2/fhs-5.15.html > On Sept. 11, 2014, 4:56 p.m., Vinod Kone wrote: > > src/slave/flags.hpp, lines 303-304 > > <https://reviews.apache.org/r/25549/diff/1/?file=686150#file686150line303> > > > > What about TaskInfo that doesn't use a ExecutorInfo. Is the default > > injected into that as well? both forms of Containerizer::launch take an ExecutorInfo which will have any default ContainerInfo added to it. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review53126 ----------------------------------------------------------- On Sept. 11, 2014, 11:46 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25549/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 11:46 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories > for each container which mask parts of the shared host filesystem. > > This review replaces https://reviews.apache.org/r/24178/ because of some file > renaming. I addressed all comments from earlier reviews. > > > Diffs > ----- > > include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 > src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee > src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 > src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > > Diff: https://reviews.apache.org/r/25549/diff/ > > > Testing > ------- > > make check # added a test > > > Thanks, > > Ian Downes > >
