----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53484 -----------------------------------------------------------
src/tests/master_tests.cpp <https://reviews.apache.org/r/25568/#comment93123> Hmm... This is not passed to StartSlave()? src/tests/master_tests.cpp <https://reviews.apache.org/r/25568/#comment93124> s/task terminal/task in terminal state/ src/tests/master_tests.cpp <https://reviews.apache.org/r/25568/#comment93126> The "Ignore subsequent offers" comment is incorrect here. src/tests/master_tests.cpp <https://reviews.apache.org/r/25568/#comment93127> What is the guarantee that offers2 will be made after task's resources are recovered? src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/25568/#comment93128> s/ensure/ensures/ src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/25568/#comment93129> s/task terminal/task in terminal state/ src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/25568/#comment93131> Why do you want to make sure that master received the reconcile tasks message? Isn't the receipt of the update guarantee that? Actually, thinking a bit more, how do you guarantee that the second update was due to reconcile tasks and not a retry by the slave? - Vinod Kone On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25568/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 2:01 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1410 > https://issues.apache.org/jira/browse/MESOS-1410 > > > Repository: mesos-git > > > Description > ------- > > Added two tests: > > (1) Ensure that reconciliation works for terminal unacknowledged tasks. > (2) Ensure that resources are released for terminal unacknowledged tasks. > > > Diffs > ----- > > src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 > src/tests/master_tests.cpp 3d080b2efad5a210353d4cef4c827380d5138d1a > src/tests/reconciliation_tests.cpp 1c9e73b0ee99a8a33f663f992b0c9770e83b98c5 > > Diff: https://reviews.apache.org/r/25568/diff/ > > > Testing > ------- > > make check, ran these new tests in repetition > > > Thanks, > > Ben Mahler > >
