> On Sept. 9, 2014, 6:50 p.m., Benjamin Hindman wrote: > > src/docker/docker.cpp, line 337 > > <https://reviews.apache.org/r/25403/diff/1/?file=680701#file680701line337> > > > > Why not move this up above as well? > > Timothy Chen wrote: > The Docker cli --entrypoint only allows you to put in a single string, > but we actually need a array of entrypoint entries (which is what docker > inspect returns). > I tried --entrypoint="/bin/sh -c" on the cli and it immediately failed. > Therefore, I have to run this in the cli: docker run --entrypoint=/bin/sh > busybox -c ls
Ah, I see, honestly this isn't obvious from the code and it's nasty that it's linked but not well scoped (so copy/paste errors are likely) so explaining why you're adding the '-c' there when you add it would probably save someone a headache in the future! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/#review52767 ----------------------------------------------------------- On Sept. 11, 2014, 12:40 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25403/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 12:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1770 > https://issues.apache.org/jira/browse/MESOS-1770 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/25403 > > > Diffs > ----- > > src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e > > Diff: https://reviews.apache.org/r/25403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
