> On Sept. 12, 2014, 9:45 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 3312 > > <https://reviews.apache.org/r/25565/diff/1/?file=687298#file687298line3312> > > > > We do have a executorLost() callback now! Just send it already and fix > > MESOS-313?
Yikes! I'm a bit weary of sneaking that in this cleanup change. There are some bigger questions around that callback, since it's not reliable I'm not sure how we'd expect frameworks to leverage it. Executors are also not reconciled correctly between the master and the slave. > On Sept. 12, 2014, 9:45 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 3828 > > <https://reviews.apache.org/r/25565/diff/1/?file=687298#file687298line3828> > > > > I think "absent in re-registration of slave" is a bit unclear for > > people reading this log line in master logs? > > > > How about "...possibly unknown to the slave"? I'm assuming you wanted > > to rephrase because slave could actually know it? The main reason I rephrased was because we now log "Removing executor" inside removeExecutor(). I've re-phrased per your comment and left a NOTE about the current issues around MESOS-1466, MESOS-1800, and MESOS-1720. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25565/#review53222 ----------------------------------------------------------- On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25565/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 2:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This adds a removeExecutor helper based on a TODO that I added awhile ago. > > Much like removeTask, removeExecutor will help avoid future resource > accounting bugs. I also cleaned up Master::finalize > > > Diffs > ----- > > src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 > src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 > > Diff: https://reviews.apache.org/r/25565/diff/ > > > Testing > ------- > > no functional change > > make check > > > Thanks, > > Ben Mahler > >
