----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25755/#review53766 -----------------------------------------------------------
Whoops, looks like the test fails for me. Since we need to fix it, can you split the patch while you're at it? I think the parsing needs to be more advanced to handle OSes with labels on the versions. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/25755/#comment93576> This test fails on my machine: [ RUN ] OsTest.release ../../../../3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp:270: Failure info: Version string has 4 components; maximum 3 components allowed $ uname -a <snip> 2.6.44-LABEL.el5 #1 SMP Tue May 13 15:46:59 PDT 2014 x86_64 x86_64 x86_64 GNU/Linux - Ben Mahler On Sept. 17, 2014, 10:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25755/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 10:50 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Version is now the preferred way for managing releases/versions. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 02a1e5842110f87cb12a917e5dc5ccadb54faacb > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 84ef49c410a08d60f77131e05e8ecfc5ed825f38 > src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 > > Diff: https://reviews.apache.org/r/25755/diff/ > > > Testing > ------- > > Ran make check > > > Thanks, > > Kapil Arya > >
