> On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 32 > > <https://reviews.apache.org/r/25847/diff/1/?file=697014#file697014line32> > > > > uint64_t? > > > > start getting ipv6 support in... ;) > > Nikita Vetoshkin wrote: > Still won't fit in ipv6 though :(
We can use <code>__uint128_t</code> ; however, I am not sure if this is supported accross all our required compilers. The larger issue is that the uint32_t type is currently baked into the protobufs, so this would be a larger compatibility change. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 ----------------------------------------------------------- On Sept. 19, 2014, 8:31 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25847/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 8:31 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Move class Node out of process.cpp and into its own header. > Part of refactoring process.cpp. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am 09f6e41 > 3rdparty/libprocess/include/process/node.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 3ac56c7 > > Diff: https://reviews.apache.org/r/25847/diff/ > > > Testing > ------- > > make check in libprocess > support/mesos-stype.py > > > Thanks, > > Joris Van Remoortere > >
