----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54024 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/25843/#comment93904> kill the if. - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25843/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 7:57 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1821 > https://issues.apache.org/jira/browse/MESOS-1821 > > > Repository: mesos-git > > > Description > ------- > > `_reregisterFramework` was not adding empty executors to a newly re-registerd > framework. > > This led to the CHECK failure in MESOS-1821. > > > Diffs > ----- > > src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 > src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d > src/tests/fault_tolerance_tests.cpp > 6f4171a2c19673b1a676c08e867d504677097bcb > > Diff: https://reviews.apache.org/r/25843/diff/ > > > Testing > ------- > > Added a test that catches the CHECK failure without the fix. > > make check > > > Thanks, > > Ben Mahler > >
