----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54141 -----------------------------------------------------------
Ship it! src/linux/cgroups.cpp <https://reviews.apache.org/r/25858/#comment94132> Not your code, but it's a little silly to do this every time... src/slave/containerizer/isolators/cgroups/cpushare.hpp <https://reviews.apache.org/r/25858/#comment94137> I don't think it's exclusively systems using systemd. What about, "(e.g., systems using systemd)" ? src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/25858/#comment94138> So cgroups::destroy gets called with col-located hierarchies? Do we not need to leave this to systemd to clean up? src/slave/slave.cpp <https://reviews.apache.org/r/25858/#comment94133> keep the NOTE on a new line? - Ian Downes On Sept. 19, 2014, 5:21 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25858/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 5:21 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and > Vinod Kone. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > A dynamic version after discussed with Tim. > https://reviews.apache.org/r/25695 > > Did a few consistency fixes as well. > > > Diffs > ----- > > src/linux/cgroups.cpp 5093b4ca1ac17238234d96613b7f4ceab4373c48 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > d4df5f37e8d2e356d35ca40d799197a47393fa9a > src/slave/containerizer/isolators/cgroups/cpushare.cpp > b1cad472a561e81422f980182fd24eb95701140a > src/slave/containerizer/isolators/cgroups/mem.cpp > fb3db88af7b2ffa79272743f571c4c021c619c48 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > ff047d37c1b2e659b18b5d4a1e97301192d05e55 > src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e > > Diff: https://reviews.apache.org/r/25858/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
