> On Sept. 23, 2014, 1 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/filesystem/shared.cpp, lines 92-99 > > <https://reviews.apache.org/r/25549/diff/3/?file=699763#file699763line92> > > > > Hmm. How is this possible given you return None() on line #75?
Sorry, changes split across two reviews. Will correct. > On Sept. 23, 2014, 1 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/filesystem/shared.cpp, line 200 > > <https://reviews.apache.org/r/25549/diff/3/?file=699763#file699763line200> > > > > include error? The error is simply that the directory doesn't exist, as detailed in the message. > On Sept. 23, 2014, 1 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/filesystem/shared.cpp, line 211 > > <https://reviews.apache.org/r/25549/diff/3/?file=699763#file699763line211> > > > > Where is "set -x" being added to commands? Should this if block be > > killed altogether? Removed in subsequent commit (which will be merged back). > On Sept. 23, 2014, 1 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 2486-2490 > > <https://reviews.apache.org/r/25549/diff/3/?file=699767#file699767line2486> > > > > Is there any particular reason the container was added to ExecutorInfo > > instead of TaskInfo? Where would this be done? At the moment both Containerizer::launch() methods take an ExecutorInfo so I'd suggest we defer adding it to the TaskInfo until this behavior is changed. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review54310 ----------------------------------------------------------- On Sept. 22, 2014, 11:45 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25549/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 11:45 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories > for each container which mask parts of the shared host filesystem. > > This review replaces https://reviews.apache.org/r/24178/ because of some file > renaming. I addressed all comments from earlier reviews. > > > Diffs > ----- > > include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 > src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee > src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 > src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 > > Diff: https://reviews.apache.org/r/25549/diff/ > > > Testing > ------- > > make check # added a test > > > Thanks, > > Ian Downes > >
