----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25948/#review54367 -----------------------------------------------------------
Ship it! src/linux/routing/diagnosis/diagnosis.hpp <https://reviews.apache.org/r/25948/#comment94506> No need to include these two? src/linux/routing/diagnosis/diagnosis.hpp <https://reviews.apache.org/r/25948/#comment94508> Can you make it const? Here and everywhere else. src/linux/routing/diagnosis/diagnosis.cpp <https://reviews.apache.org/r/25948/#comment94504> Fix the indent. src/linux/routing/diagnosis/diagnosis.cpp <https://reviews.apache.org/r/25948/#comment94507> No need for this helper. src/linux/routing/diagnosis/diagnosis.cpp <https://reviews.apache.org/r/25948/#comment94505> (State) idia... - Jie Yu On Sept. 23, 2014, 11:18 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25948/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 11:18 p.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Bugs: Mesos-1808 > https://issues.apache.org/jira/browse/Mesos-1808 > > > Repository: mesos-git > > > Description > ------- > > see Summary. > > > Diffs > ----- > > configure.ac da61c29 > src/Makefile.am 9b973e5 > src/linux/routing/diagnosis/diagnosis.hpp PRE-CREATION > src/linux/routing/diagnosis/diagnosis.cpp PRE-CREATION > src/linux/routing/internal.hpp dca0dc5 > src/tests/routing_tests.cpp 10730ad > > Diff: https://reviews.apache.org/r/25948/diff/ > > > Testing > ------- > > added a test to use the code path. > > > Thanks, > > Chi Zhang > >
