----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26060/#review54612 -----------------------------------------------------------
3rdparty/libprocess/src/event_manager.hpp <https://reviews.apache.org/r/26060/#comment94805> i'm missing some subtlety here about needing both the internal::EventManager and EventManager. If http_proxy requires EventManager::send then it should be in EventManager, and we don't need the base class. What am I missing? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26060/#comment94801> override may not be supported in g++-4.4. We don't use it anywhere else. - Dominic Hamon On Sept. 25, 2014, 3:01 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26060/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 3:01 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Move http_proxy out of process.cpp, which forces the bare scaffolding for the > event_manager abstraction dependency injection. > For now: SocketManager -> EventManager -> internal::EventManager. > In this step we only virtualized (raised) the mandatory send() functions. > internal::EventManager exists to inject only the functions that http_proxy > depends on. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 616618e > 3rdparty/libprocess/src/event_manager.hpp PRE-CREATION > 3rdparty/libprocess/src/event_manager_base.hpp PRE-CREATION > 3rdparty/libprocess/src/http_proxy.hpp PRE-CREATION > 3rdparty/libprocess/src/http_proxy.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp e46e6b1 > > Diff: https://reviews.apache.org/r/26060/diff/ > > > Testing > ------- > > make check > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
