----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review54793 -----------------------------------------------------------
Ship it! LGTM. Just minor comments. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp <https://reviews.apache.org/r/25818/#comment95061> Nit: s/don't/Don't/ and add a blank line before comments. 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp <https://reviews.apache.org/r/25818/#comment95062> Aren't two of these lines the same? Am I missing something? 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp <https://reviews.apache.org/r/25818/#comment95063> Excuse my ignorance of variadic templates, but could one write path::join("/") or path::join("")? If those would compile, they would be easy edge cases. - Adam B On Sept. 27, 2014, 3:53 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25818/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 3:53 p.m.) > > > Review request for mesos, Adam B and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Switch path::join() to be variadic. > > Updated now that 25789 has landed > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am bd1dc8d > 3rdparty/libprocess/3rdparty/stout/Makefile.am 2ee5a0b > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 14567f1 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25818/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cody Maloney > >
