----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26069/#review54806 -----------------------------------------------------------
How much fine-tuning can we apply here? Between this and cpplint.py will we "cover" out style completely? Looking forward to helping make folks more productive but don't want to frustrate people that use this and then still get comments on their reviews about needing to make changes to be consistent with our style. :-/ support/clang-format <https://reviews.apache.org/r/26069/#comment95081> This is actually not "good", since the '{' is not on a newline. I guess this is just for checking the access modifier offset, but it could be counter-intuitive for people. support/clang-format <https://reviews.apache.org/r/26069/#comment95083> We haven't had a hard rule about this, so if someone manually aligns them where that might make sense will ClangFormat un-align them? support/clang-format <https://reviews.apache.org/r/26069/#comment95084> Can ClangFormat differentiate when to do: allocator->resourcesRecovered( frameworkId, slaveId, resources, filters); instead of: allocator->resourcesRecovered(frameworkId, slaveId, resources, filters); support/clang-format <https://reviews.apache.org/r/26069/#comment95085> Can we fine-tune this? We break for function, class, struct, etc, but not for namespaces. - Benjamin Hindman On Sept. 29, 2014, 9:10 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26069/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 9:10 a.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and > Timothy Chen. > > > Bugs: MESOS-1291 > https://issues.apache.org/jira/browse/MESOS-1291 > > > Repository: mesos-git > > > Description > ------- > > We spend way too much of our time formatting, not to mention the amount of > time wasted during the review cycle to address style issues. Let’s get > ClangFormat to help us! > > If you don't know what ClangFormat is or how it works, take a look at the > Chandler Carruth's [live > demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to > 33m 27s. > > Further details and analysis are available > [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing). > > > Diffs > ----- > > .clang-format PRE-CREATION > support/clang-format PRE-CREATION > > Diff: https://reviews.apache.org/r/26069/diff/ > > > Testing > ------- > > Refer to the __Sample Diff__ section in the [Google > Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing) > > > Thanks, > > Michael Park > >
