----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/#review54857 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/Makefile.am <https://reviews.apache.org/r/24535/#comment95171> Should we add some check in configure.ac? Also, seems that not all distributions install headers under apr-1: http://packages.ubuntu.com/trusty/amd64/libaprutil1-dev/filelist 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/24535/#comment95314> Do we need to do the pool allocation everytime? Or could we just do it once? I am not sure whether would cause any performance issue or not. 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/24535/#comment95188> This seems to be deprecated. http://subversion.apache.org/docs/api/latest/group__svn__delta__txt__delta.html#gaf7354f923339d3338c3083e91bfee472 Consider using svn_txdelta_to_svndiff3? 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/24535/#comment95189> This is deprecated as well. 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/24535/#comment95172> destroy pool before return? 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp <https://reviews.apache.org/r/24535/#comment95173> destroy pool before return? - Jie Yu On Sept. 29, 2014, 12:45 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24535/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 12:45 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > Note that this hard codes the location of the subversion and Apache Portable > Runtime (APR) headers. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > bd1dc8df0259a318a9171a9c045a223800e64f47 > 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/24535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
