----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26236/#review55101 -----------------------------------------------------------
Ship it! src/linux/routing/diagnosis/diagnosis.hpp <https://reviews.apache.org/r/26236/#comment95462> Remove this comment. Instead, comment that for 'infos' function. src/linux/routing/diagnosis/diagnosis.hpp <https://reviews.apache.org/r/26236/#comment95461> Add a comment about 'states'. It accepts multiple states using bitwise OR. - Jie Yu On Oct. 1, 2014, 6:01 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26236/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 6:01 p.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Bugs: mesos-1808 > https://issues.apache.org/jira/browse/mesos-1808 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/linux/routing/diagnosis/diagnosis.hpp aa1b3a3 > src/linux/routing/diagnosis/diagnosis.cpp 36e4e2d > src/tests/routing_tests.cpp 179f50b > > Diff: https://reviews.apache.org/r/26236/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
