----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55147 -----------------------------------------------------------
Bad patch! Reviews applied: [26247] Failed command: ./support/mesos-style.py Error: Checking 510 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/slave/status_update_manager.cpp:571: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] src/slave/status_update_manager.cpp:609: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4] Total errors found: 2 - Mesos ReviewBot On Oct. 1, 2014, 9:30 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26247/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 9:30 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > These are changes necessary from removing `<stout/preprocessor.hpp>` from > `stout` and `libprocess`. > With the preprocessor expansion, taking the address of an overloaded function > was disambiguated by the number of arguments. > The number of arguments a function takes is not a reliable disambiguation > mechanism, we `static_cast` them to a specific signature as we do in other > parts of the code where disambiguation of overloaded functions is necessary. > > > Diffs > ----- > > src/log/replica.cpp c18de86f2659b848b0e8f0468e4efa820d048970 > src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223 > src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6 > src/slave/containerizer/composing.cpp > 9022700b628d9746a6a8a17c9fbf1b1988da6fca > src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/status_update_manager.cpp > 5d5cf234ef2dd47fa4b1f67be761dbca31659451 > src/zookeeper/zookeeper.cpp d4c24cd500b74d3b979a471b4a32def78958f04a > > Diff: https://reviews.apache.org/r/26247/diff/ > > > Testing > ------- > > `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, > `clang-3.3` and `clang-3.5` > > > Thanks, > > Michael Park > >
