----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26204/#review55148 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/26204/#comment95531> Pull this down too as you did for _registerSlave() ? - Vinod Kone On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26204/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:31 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > I wanted to avoid the need for both `addSlave()` and `readdSlave`. > > Now, the responsibility of `addSlave()` is only to add a `Slave` struct into > the master's state. Callers are responsible for telling a slave that is is > registered after adding it. > > This means the `Slave` constructor optionally takes executors and tasks. > > > Diffs > ----- > > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > > Diff: https://reviews.apache.org/r/26204/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
