----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26253/#review55164 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/26253/#comment95548> If inet_ntop returns NULL you should log a PLOG(FATAL) message. - Jay Buffington On Oct. 1, 2014, 11:34 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26253/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 11:34 p.m.) > > > Review request for mesos and Jay Buffington. > > > Bugs: MESOS-1835 > https://issues.apache.org/jira/browse/MESOS-1835 > > > Repository: mesos-git > > > Description > ------- > > Replaced ip value comparison with 2130706433 or 0 with inet_ntop and string > comparison to avoid endianess problems > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > d30ed636ee24d0fe6e62f69a921307bde1f32765 > > Diff: https://reviews.apache.org/r/26253/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
