> On Sept. 25, 2014, 3:27 p.m., Vinod Kone wrote: > > src/tests/isolator_tests.cpp, line 446 > > <https://reviews.apache.org/r/24177/diff/3/?file=703418#file703418line446> > > > > probably not part of this review, but we avoid this pattern because it > > could lead to leaked temp directories if the test fails. > > > > since you are already inside a sandbox (because you inherit from > > TemporaryDirectoryTest), you should use relative paths to create temporary > > directories. > > > > s/os::mkdtemp()/os::mkdtemp("./XXXXXX")/ > > > > mind adding a TODO?
FYI - relative paths don't work so path::join(os::getcwd(), "XXXXXX")) - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24177/#review54618 ----------------------------------------------------------- On Oct. 2, 2014, 11:18 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24177/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 11:18 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Pass executor directory to Isolator::prepare(). > > Will be used for FilesystemIsolator. > > > Diffs > ----- > > src/slave/containerizer/isolator.hpp > e52e8b15c740c62ef64b49897d3d6ae5179d4719 > src/slave/containerizer/isolator.cpp > 5e61bf2e3cf14be53d41aa657b4a78ab2dd6ecb0 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 2187c296ea9b1a7de9ae3f09fdf1983f98a3d01b > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 7164ecc0f068d4a72248521e3cbd345958efa880 > src/slave/containerizer/isolators/cgroups/mem.hpp > b1b4f5a2bd9e01b03fdfa74f187f7dee8119b812 > src/slave/containerizer/isolators/cgroups/mem.cpp > b3d4a5daa90a842e501bc6be2f0cf20fe22906ac > src/slave/containerizer/isolators/cgroups/perf_event.hpp > f7283d830cd6af7b3c9006c098de0a6ad48b7c82 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 4ced508e600e13f3e5ae9d12ea199de743def652 > src/slave/containerizer/isolators/network/port_mapping.hpp > b624c4d2f2b2d635bb3fd49db46d3f23262312e4 > src/slave/containerizer/isolators/network/port_mapping.cpp > 2766a00ff81dc550c21387f920666f81705db4f0 > src/slave/containerizer/isolators/posix.hpp > f120aafef96343d84f93c5636484509dc972a0a8 > src/tests/isolator.hpp 89df4c4959c680354b002fa12e3a270a358087af > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/port_mapping_tests.cpp 0389f4034e2582691068855305e23f2364f72f4a > > Diff: https://reviews.apache.org/r/24177/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
