> On Oct. 1, 2014, 9:19 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp, line 28 > > <https://reviews.apache.org/r/26245/diff/1/?file=710326#file710326line28> > > > > How often is this construction used? According to > > https://gcc.gnu.org/gcc-4.4/cxx0x_status.html initializer lists existed in > > 4.4, so we should be able to remove the custom stout List other than as a > > template alias and move to initializer_list as Ben Mahler's TODO said here. > > > > Same concept goes for Set below.
Removed `<stout/list.hpp>`. The only place it was used was in `3rdparty/libprocess/src/tests/timeseries_tests.cpp`. Changed to `std::vector`. We should be using `std::vector` anyway. > On Oct. 1, 2014, 9:19 p.m., Cody Maloney wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp, line 19 > > <https://reviews.apache.org/r/26245/diff/1/?file=710328#file710328line19> > > > > The header guard + lead comment changes seem independent of the removal > > of the preprocessor usage. Would it make sense to split that out as a > > seperate patch (Which will likely get fairly quickly committed)? I think the guard + lead comments changes I made here are minor enough that it can just wait for this patch to get merged. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26245/#review55131 ----------------------------------------------------------- On Oct. 5, 2014, 6:57 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26245/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2014, 6:57 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > With variadic template support now required in Mesos, the preprocessor > expansion technique is no longer necessary. Remove its usage in stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > d4a8ad4e776bcfe1f008e561b5a92340f4d84bd9 > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 719aa964a536cf02dbd2de440157de487ec703b1 > 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp > d75f0f19f5515fafe2f3e0d4318e8ebc79ba1cfa > 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp > 60f0c8c67317872883857a1cd8f39d6d6a45d0c1 > 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp > deb8df315dc121e8318584d09797667f7d3743e5 > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp > ea8a13f25d72bb645842d32a91b168b67d33c3eb > 3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp > b121836112aa62c98d925d5463ef144890d96a4b > 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp > cdedacde1247e766e240ea1c2d86573c6ecccafd > > Diff: https://reviews.apache.org/r/26245/diff/ > > > Testing > ------- > > `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, > `clang-3.3` and `clang-3.5` > > > Thanks, > > Michael Park > >
