----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26389/#review55620 -----------------------------------------------------------
Ship it! src/sasl/authenticatee.hpp <https://reviews.apache.org/r/26389/#comment95984> Does this belong in finalize(), when the process is terminating? IMO this comment isn't necessary, we've used this finalize() Promise discard pattern many times in the code: TasksKiller NetworkProcess LogStorageProcess LogWriterProcess LogReaderProcess ExplicitPromiseProcess ImplicitPromiseProcess FillProcess WriteProcess CatchupProcess BulkCatchupProcess ExistenceChecker ... etc Not sure if we need such a verbose comment in all of these finalize() methods, this bug seems like an oversight to me. src/sasl/authenticator.hpp <https://reviews.apache.org/r/26389/#comment95985> Ditto comments above. - Ben Mahler On Oct. 7, 2014, 12:19 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26389/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 12:19 a.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Jie Yu. > > > Bugs: MESOS-1866 > https://issues.apache.org/jira/browse/MESOS-1866 > > > Repository: mesos-git > > > Description > ------- > > This fixes the race condition #2 as discussed in MESOS-1866. > > > Diffs > ----- > > src/sasl/authenticatee.hpp dd68704c4851d28114dd632cd8e16882b2e30ebe > src/sasl/authenticator.hpp 35ab79449093e10877248b91ba7070e04c9cdd6f > src/tests/sasl_tests.cpp 59e1c95370879d4b006bfd80f16ce2a1f54a61df > > Diff: https://reviews.apache.org/r/26389/diff/ > > > Testing > ------- > > Ensured that the test failed without the fix. > > Ran the test 10K times in repitition with the fix. > > make check > > > Thanks, > > Vinod Kone > >
