----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26396/#review55624 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/26396/#comment95987> a tab snuck in here. kernel code format settings? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26396/#comment95988> for the record, this isn't completely accurate. see https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/statistics.hpp#L76 for how to correctly interpolate for statistics. or use the TimeSeries to track RTTs and use the statistics code directly instead of reinventing the wheel. - Dominic Hamon On Oct. 6, 2014, 5:38 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26396/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 5:38 p.m.) > > > Review request for mesos, Chi Zhang and Ian Downes. > > > Bugs: MESOS-1808 > https://issues.apache.org/jira/browse/MESOS-1808 > > > Repository: mesos-git > > > Description > ------- > > See summary. I did a few cleanup too. > > > Diffs > ----- > > include/mesos/mesos.proto f536017ce15fad7917818a30e91e6ff45602cf16 > src/slave/containerizer/isolators/network/port_mapping.hpp > 5bc7edd8a3d9c9095226f6e21df3e7a3d180ab48 > src/slave/containerizer/isolators/network/port_mapping.cpp > 88ae509f7962ae90a76823f91083ab27bef2be1e > src/tests/port_mapping_tests.cpp 53ba8f30b12a8b89c22c357a5930fe34ba2da445 > > Diff: https://reviews.apache.org/r/26396/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
