----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26392/#review55623 -----------------------------------------------------------
Ship it! src/master/http.cpp <https://reviews.apache.org/r/26392/#comment95989> add "used_resources" and "offered_resources" keys with a TODO to deprecate "resources". for framework and slave. src/master/master.cpp <https://reviews.apache.org/r/26392/#comment95986> CHECK_NOTNULL(task); - Vinod Kone On Oct. 7, 2014, 12:38 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26392/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 12:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1862 > https://issues.apache.org/jira/browse/MESOS-1862 > > > Repository: mesos-git > > > Description > ------- > > In order to avoid the slow resource summation, I've reverted the master logic > to use counter Resources objects to maintain the used resources and offered > resources in the `Slave` and `Framework` structs. > > This now requires a call to notify the struct that the task has terminated, > since we hold on to terminal tasks. > > > Diffs > ----- > > src/master/http.cpp 16a6a015fc4dab1f5f7e5a0b55448d306b90732a > src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f > src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e > > Diff: https://reviews.apache.org/r/26392/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
