> On Sept. 27, 2014, 12:09 a.m., Kapil Arya wrote: > > src/Makefile.am, line 567 > > <https://reviews.apache.org/r/25551/diff/2/?file=706149#file706149line567> > > > > Dumb question: Shouldn't MAJOR/MINOR be swapped?
I'm pretty sure it's correct, but the api is... obtuse. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25551/#review54753 ----------------------------------------------------------- On Sept. 26, 2014, 3:31 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25551/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 3:31 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-1675 > https://issues.apache.org/jira/browse/MESOS-1675 > > > Repository: mesos-git > > > Description > ------- > > Add standard -version-info to shared libmesos, it will need to be updated on > major modifications. > > > Diffs > ----- > > configure.ac 86d448c > src/Makefile.am 27c42df > > Diff: https://reviews.apache.org/r/25551/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
