----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26206/#review55922 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/26206/#comment96291> Kill this. I think we should always use SUM in the slave when sending updates. - Vinod Kone On Oct. 9, 2014, 12:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26206/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 12:14 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1696 > https://issues.apache.org/jira/browse/MESOS-1696 > > > Repository: mesos-git > > > Description > ------- > > The master must rely on the slave to reconcile tasks that were missing in the > re-registration message. Otherwise, the master may incorrectly send TASK_LOST > in the event of a race. > > See MESOS-1696 for further details. > > > Diffs > ----- > > src/master/master.hpp 37ce31abb45b6d1c4a9c88b0f1e81d1265d382b9 > src/master/master.cpp 0286353babdb1ef44ed954e19f02998bc272a6c7 > src/messages/messages.proto b8039efa1638995c2846f5cb515919d5e51cde5c > src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0 > src/slave/slave.cpp 809b008b1502b80cce4d8b4be0a233117c92ed56 > src/tests/fault_tolerance_tests.cpp > e8f532232c091849489971d7fc96ae615ffb6de0 > > Diff: https://reviews.apache.org/r/26206/diff/ > > > Testing > ------- > > make check, and modified the test that captured the TASK_LOST case. Added > another test in a subsequent review. > > > Thanks, > > Ben Mahler > >
