> On Oct. 9, 2014, 3:49 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > <https://reviews.apache.org/r/26472/diff/1/?file=716305#file716305line36> > > > > it might be worth considering using stringstream here to build the same > > error message we had before. > > > > we will have a stack trace, but having the thing that was attempting to > > stringify could be useful too, i think. > > Adam B wrote: > +1 on "having the thing that was attempting to stringify could be useful"
The thing is we would be doing the same operation which just failed in order to try to print out T again. So in the failure case (Which is unlikely to fail unless you are OOM), we have the operation fail, then try the failed thing again in order to provide debug information. I'm planning to make ABORT() give backtraces on debug builds, which should provide a lot more information than this ever possibly did, without retrying something we know is likely to fail because it just did. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review55946 ----------------------------------------------------------- On Oct. 9, 2014, 1:20 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26472/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 1:20 a.m.) > > > Review request for mesos, Adam B and Dominic Hamon. > > > Bugs: MESOS-1870 > https://issues.apache.org/jira/browse/MESOS-1870 > > > Repository: mesos-git > > > Description > ------- > > This makes it so any time there is an abort, we get a line number and at > least a basic message as to why there was an abort. If you want a clean(er) > exit, use <stout/exit>. > > Also adds an overload which takes a standard string and unwraps it to a const > char * automatically, since a lot of the time we are building strings to pass > them to abort. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 6b5b5d1 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9d244b2 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7138bc2 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 8aa21ed > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp ccf80a7 > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp ed0a1ef > 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp b1af74f > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9207c55 > > Diff: https://reviews.apache.org/r/26472/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
