> On Oct. 9, 2014, 9:14 a.m., Adam B wrote: > > 3rdparty/libprocess/src/httpd.cpp, lines 32-37 > > <https://reviews.apache.org/r/26473/diff/1/?file=716312#file716312line32> > > > > Why are you removing this here? Doesn't seem related to the abort > > change. Or did you just notice that these are completely unused?
They were using abort(), so they fell into the category of upgrade or remove. They weren't used at all, so I just removed them rather than maintain the old cruft. Would you prefer I pull it out into a seperate patch next time? - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26473/#review55963 ----------------------------------------------------------- On Oct. 9, 2014, 4:38 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26473/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 4:38 p.m.) > > > Review request for mesos, Adam B and Dominic Hamon. > > > Bugs: MESOS-1870 > https://issues.apache.org/jira/browse/MESOS-1870 > > > Repository: mesos-git > > > Description > ------- > > This makes it so any time there is an abort, we get a line number and at > least a basic message as to why there was an abort. If you want a clean(er) > exit, use <stout/exit>. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > bf689d7270df2c8f1f5c9165d2bbcfdca06e15a8 > 3rdparty/libprocess/include/process/http.hpp > d5407755a51a6edf779b2d219b4d81a90c3af2f8 > 3rdparty/libprocess/include/process/socket.hpp > dbcb4f4c2eb12663158057a844b4511d6dde0508 > 3rdparty/libprocess/src/httpd.cpp eab3aa5f1c74cfc211b0efcc40f984222c85785c > 3rdparty/libprocess/src/synchronized.hpp > 70f6cd06825ac7bde5e45f2a900d2b2659e02b6e > > Diff: https://reviews.apache.org/r/26473/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Cody Maloney > >
