> On Oct. 7, 2014, 9:23 p.m., Ben Mahler wrote: > > src/slave/containerizer/linux_launcher.cpp, line 362 > > <https://reviews.apache.org/r/25865/diff/3/?file=711229#file711229line362> > > > > This line is unused...? > > Ian Downes wrote: > It's used in the os::getns call below. I capture it so I can erase from > the map in one place before any return code paths.
I'm confused, there's no os::getns scope in this method...? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25865/#review55685 ----------------------------------------------------------- On Oct. 2, 2014, 6:23 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25865/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 6:23 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Add namespaces/pid to --isolation slave flag. Places executor into a pid > namespace so it and all descendants will be contained in the namespace. > Requires the filesystem/shared isolator so /proc and /sys are remounted to > reflect the different namespace. > > > Diffs > ----- > > src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/isolators/namespaces/pid.hpp PRE-CREATION > src/slave/containerizer/isolators/namespaces/pid.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > f7bc894830a7ca3f55465dacc7b653cdc2d7758b > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > > Diff: https://reviews.apache.org/r/25865/diff/ > > > Testing > ------- > > Added test that command in pid namespaced container is in a different > namespace and that the command is 'init' (verifies remount of /proc). > > > Thanks, > > Ian Downes > >
