> On Oct. 10, 2014, 5:04 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 1453 > > <https://reviews.apache.org/r/26533/diff/1/?file=717191#file717191line1453> > > > > should these be std::unique_ptr instead? (i'm currently adding support > > for this to the libprocess configure check).
Indeed. I have some follow up patches that will try to tackle the actual clean shutdown. This initial patch it to try and introduce a place to close the loop. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56166 ----------------------------------------------------------- On Oct. 10, 2014, 1:02 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26533/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 1:02 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Introduce a finalize() function to match the initialize() function in > process.hpp. Use this at the unit test runner for libprocess to start getting > more valuable valgrind feedback. > - Added cleanup of remaining Processes in ~ProcessManager() as a start. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp 270ca28 > 3rdparty/libprocess/src/process.cpp d30ed63 > 3rdparty/libprocess/src/tests/main.cpp 0a3ba4e > > Diff: https://reviews.apache.org/r/26533/diff/ > > > Testing > ------- > > make check > support/mesos-style > valgrind 3rdparty/libprocess/tests (to see a reduction in definitely lost > blocks) > > > Thanks, > > Joris Van Remoortere > >
