> On Oct. 10, 2014, 5:02 p.m., Dominic Hamon wrote: > > src/master/registrar.cpp, line 193 > > <https://reviews.apache.org/r/26535/diff/1/?file=717211#file717211line193> > > > > could you use the metrics timer instead (and still log the result) so > > that it is exposed on the metrics endpoint?
Sounds good, let me try to land benh's patch to make this possible: r/24537 - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26535/#review56165 ----------------------------------------------------------- On Oct. 10, 2014, 1:51 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26535/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 1:51 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We currently lack logging visibility into the batch sizes in the registrar. > > While we have timing metrics, we also lack the ability to easily read timings > for particular operations. > > > Diffs > ----- > > src/master/registrar.cpp ccc2fd23b1a1d56ab327cc73f6fef35d4bf6a552 > > Diff: https://reviews.apache.org/r/26535/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
