----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26525/ -----------------------------------------------------------
(Updated Oct. 10, 2014, 8:40 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes ------- Vinod's comments. Repository: mesos-git Description ------- There are two places where 'new Executor' is called: 1) launchExecutor 2) recoverExecutor For 2), we don't need checkpointing. Therefore, putting checkpointing code in Executor constructor and use state != RECOVERING to disginguish is not explicit and confusing. Diffs (updated) ----- src/slave/slave.hpp 76d505c src/slave/slave.cpp cb37599 Diff: https://reviews.apache.org/r/26525/diff/ Testing ------- make check Thanks, Jie Yu
