----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/#review56292 -----------------------------------------------------------
Ship it! src/docker/docker.cpp <https://reviews.apache.org/r/26487/#comment96600> Great comment! Let's not lose the CHECK_SOME(s.out()) from below though please. src/docker/docker.cpp <https://reviews.apache.org/r/26487/#comment96599> Can you not make this const? src/docker/docker.cpp <https://reviews.apache.org/r/26487/#comment96601> How about putting the .then on the next line to make it even easier to read? This is also the prevailing style (see the rest of the .then's in this file, for example). - Benjamin Hindman On Oct. 9, 2014, 9:38 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26487/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 9:38 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1885 > https://issues.apache.org/jira/browse/MESOS-1885 > > > Repository: mesos-git > > > Description > ------- > > Perform read right after subprocess for docker ps > > > Diffs > ----- > > src/docker/docker.hpp 7972edaf3038e70b6a5ed369f9b8de0c644fc4b0 > src/docker/docker.cpp 20be6cd4649e12ed6f7d5d1991b5040342c56f35 > > Diff: https://reviews.apache.org/r/26487/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
