> On Oct. 11, 2014, 12:15 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 1635 > > <https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1635> > > > > should do the same for this while you're here.
Since help is covered by the garbage collector it doesn't make sense to wrap it with a unique_ptr; otherwise we would have to .release() it to prevent a double free. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review56262 ----------------------------------------------------------- On Oct. 10, 2014, 11:12 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26583/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 11:12 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Wrap the libprocess garbage collector process with a unique ptr. Reset the > ptr during finalization. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/26583/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
