-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26634/#review56504
-----------------------------------------------------------
It looks to me that adding this functionality imposes a restriction on key
names in JSON. We won't be able to do something like this:
object.values["name_[en]_full"] = "Name";
auto result = object.find<JSON::String>("name_[en]_full");
I don't think it is a big deal or we would need it, but maybe let's make this
restriction explicit by introducing a vaidation function.
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
<https://reviews.apache.org/r/26634/#comment96872>
How about a one-liner with one intermediate object less? `std::string
subscript = name.substr(index + 1, name.length() - index - 2);`
- Alexander Rukletsov
On Oct. 13, 2014, 4:54 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26634/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 4:54 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
> 719aa964a536cf02dbd2de440157de487ec703b1
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
> 3bfc8e639185323a3809ca82c09428b3b1b8afe5
>
> Diff: https://reviews.apache.org/r/26634/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
