----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review56573 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/26426/#comment96918> Typical pattern is yes/no vs. true/false. Not that it really matters, more for consistency. configure.ac <https://reviews.apache.org/r/26426/#comment96919> Is there a reason you want to leave debug symbols out of optimized builds? cmake has the pattern correct imho: Release Debug ReleaseWithDebug A ReleaseWithDebug allows packagers, such as myself, to build w/debugsymbols that are stripped out into a .debuginfo package which can be used by developers for tracing "When bears attack". Granted that it is tenuous debugging at best, but it's better then nothing. So I think we want all three modes, stripping all debug information is not really idea. - Timothy St. Clair On Oct. 7, 2014, 10:38 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26426/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 10:38 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy St. Clair. > > > Repository: mesos-git > > > Description > ------- > > Reworks building mesos in "debug" vs. "release". By default, mesos is now > built in release (no debug info, optimized build). If '--enable-debug' is > specified to configure, than optimization will be turned off, and debug info > will be turned on. > > This also adds a variable 'DEBUG' to the build environment, which people can > use in code to see if mesos is built with debugging to enable extra > assertions / checks. For release builds we may want to set 'NDEBUG' which > removes assert()'s, but that is a seperate discussion. > > Main benefits: > 1) Getting a build to include/exclude debug information at will is feasible. > Before some things like using clang would forcibly enable debug info in all > cases > 2) libmesos.so and the other binaries which get packaged up for use in > distributions shrink considerably without manually stripping post-build > (Improves build time, makes packaging cleaner) > > > Diffs > ----- > > configure.ac da1c82db31583fc81de658574b9a95628cb84dbc > > Diff: https://reviews.apache.org/r/26426/diff/ > > > Testing > ------- > > Built with both --enable-debug and without, checking that the flags get > passed through correctly. > > > Thanks, > > Cody Maloney > >
