> On Oct. 14, 2014, 10:18 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 472 > > <https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472> > > > > Since this method doesn't simple kill anymore, can you also refactor > > the method name? Good to provide some comments as well in the header that > > it stops and kills after a period of time. > > > > 30 seconds also seems a bit long to me, but regardless we should at > > least make a constant that we can change later.
Also did you try to run all the docker unit tests? - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26709/#review56585 ----------------------------------------------------------- On Oct. 14, 2014, 9:56 p.m., Ryan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26709/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 9:56 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1925 > https://issues.apache.org/jira/browse/MESOS-1925 > > > Repository: mesos-git > > > Description > ------- > > Change docker kill to docker stop to allow graceful shutdown of containers. > > > Diffs > ----- > > src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2 > > Diff: https://reviews.apache.org/r/26709/diff/ > > > Testing > ------- > > > Thanks, > > Ryan Thomas > >
