----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26715/#review56741 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/26715/#comment97121> s/simply/simplify/ 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/26715/#comment97120> shouldn't this be a hex value? also, why are the hex values different for linux and apple? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/26715/#comment97129> s/setting/result/ ? - Vinod Kone On Oct. 15, 2014, 12:24 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26715/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 12:24 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This patch allows us to use O_CLOEXEC even if it's not available on some > distributions. > > Will follow up with a patch to cleanup the code. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > ec41fe412290a152a15a49e091f0bc6436e42cfd > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 898d175980e397493270454aafdf340a96c9cf85 > > Diff: https://reviews.apache.org/r/26715/diff/ > > > Testing > ------- > > make check > > both on mac and linux > > > Thanks, > > Jie Yu > >
